Add simple benchmark script #180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
scripts/run_bench.pyand a GH workflow that runs it nightly or can be manually triggered__main__moduleResults
(if not wanting horizontal scrollbars on table, open dev console and remove
overflowCSS property for.markdown-body tableclass...I don't feel like reworking the tables)Sandboxed
Unsandboxed
Notes
Notes:
linuxrunner is our 4-core org-level one and thewindowsrunner is the GH-provided onemax_concurrentup there applies to bothmax_concurrent_workflow_tasksandmax_concurrent_activities(set as the same number for now)linuxwarnings and errors happen when stopping Temporalite via the Rust ephemeral server shutdown. We are probably not doing this right.max_cached_workflowsis1000,max_concurrent_workflow_tasksis100, andmax_concurrent_activitiesis100. In light of these numbers above, should we increase those? Also note wrt activities it affects sync activities too.Things that could be added but weren't:
The goal of this project was to just ensure the SDK was good enough performance wise. We'll need to spend more time optimizing.
Checklist